Skip to content

Feature/#144 add download button#145

Open
ortiztena wants to merge 6 commits intoLemoncode:masterfrom
ortiztena:feature/#144-add-download-button
Open

Feature/#144 add download button#145
ortiztena wants to merge 6 commits intoLemoncode:masterfrom
ortiztena:feature/#144-add-download-button

Conversation

@ortiztena
Copy link
Copy Markdown

added download button functionality.
added date when it generates the txt file.
edited css file.

element.href = URL.createObjectURL(file);
element.download = `Codepaster_Session_${dateNow}.txt`;
element.click();
};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not using prettier formatting, @manudous will guide you setting up this

https://www.lemoncode.tv/curso/prettier

Comment thread front/src/common/log-download.ts Outdated
@@ -0,0 +1,10 @@
export const handleDownSessionContent = (sessionContent: string) => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather

handleDownloadSessionContent

Comment thread front/src/common/log-download.ts Outdated

max-width:50%;

}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be simplified since we are using material ui?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added spacing method instead of "50%"

}
`;

export const downButton = css`
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is twice?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to downloadButton and downloadIcon

Copy link
Copy Markdown
Author

@ortiztena ortiztena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants